improve: upgrade to Gatsby v4 #3182
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
b32e376
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://2ff2a31b.orbit.pages.dev |
|
Size Change: -3.71 kB (-1%) Total Size: 484 kB
ℹ️ View Unchanged
|
|
The problem with updating the babel is still persist, bundle size increased on 164kb |
mainframev
reviewed
Nov 10, 2021
Yeah, that was not meant to fix the file size problem, it was something else. I'll let you know when I find the fix for file size. |
|
The change that is needed here is to get rid of |
silvenon
force-pushed
the
master
branch
2 times, most recently
from
bb9bfd3
to
d509c37
Compare
mainframev
force-pushed
the
improve/gatsby4
branch
5 times, most recently
from
d3c0560
to
b32e376
Compare
mainframev
force-pushed
the
improve/gatsby4
branch
from
b32e376
to
2998916
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's nothing in here that's actually taking advantage of new Gatsby yet, but no harm in upgrading it anyway, we can start using the features later.
Gatsby 3+ was throwing because we were using Babel packages on client side that didn't support running in the browser environment. We probably could have done some more webpack configuration magic to get around that, but instead we switched to
@babel/standalone, which is meant to exactly for these uses cases and is simpler to use.Storybook: https://orbit-silvenon-improve-gatsby4.surge.sh