-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move Label component out of Input folder and let it accept for Typography "types" #66
Closed
2 of 4 tasks
Comments
I didn't specify form inputs yet, but it'll be done in next days, but... Are we sure we need own component for this? If it's only because of visual look, we will solve visual consistency (and easy updating) with use of design tokens. |
@darkwindcz Can I close it ? |
@tomashapl I think you can. |
@tomashapl Yes |
bul-nick-al
pushed a commit
to bul-nick-al/orbit
that referenced
this issue
Aug 19, 2022
…adding-and-spacing Simplify Card content padding and spacing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
It seems Label can be used not only for
Input
-based types but also for other cases such asSelect
. I suggest to:Label
to its own folder.Label
accept differenttype
props, so theTypography
color it is using is more flexible. Currently it can only be eithersecondary
orprimary
, which is not enough forSelect
for example.Make sure these boxes are ticked before submitting a new issue:
The text was updated successfully, but these errors were encountered: