Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Label component out of Input folder and let it accept for Typography "types" #66

Closed
2 of 4 tasks
git-toni opened this issue Mar 7, 2018 · 4 comments
Closed
2 of 4 tasks

Comments

@git-toni
Copy link
Contributor

git-toni commented Mar 7, 2018

It seems Label can be used not only for Input-based types but also for other cases such as Select. I suggest to:

  • Move Label to its own folder.
  • Let Label accept different type props, so the Typography color it is using is more flexible. Currently it can only be either secondary or primary, which is not enough for Select for example.

Make sure these boxes are ticked before submitting a new issue:

  • I have checked that this is not a duplicate
  • I have added a label categorizing this under BLKN | Kiwicom | Icons | Global
@git-toni git-toni added the BLKN label Mar 7, 2018
@fallion fallion added this to the Kiwi-Ui 0.1 milestone Mar 7, 2018
@fallion fallion removed the BLKN label Mar 13, 2018
@honzatmn
Copy link
Contributor

I didn't specify form inputs yet, but it'll be done in next days, but... Are we sure we need own component for this? If it's only because of visual look, we will solve visual consistency (and easy updating) with use of design tokens.

@honzatmn honzatmn removed this from the Orbit Components 0.1 milestone Apr 26, 2018
@tomashapl
Copy link
Contributor

@darkwindcz Can I close it ? <FormLabel /> is available since #219

@vepor
Copy link
Contributor

vepor commented Jun 25, 2018

@tomashapl I think you can.

@honzatmn
Copy link
Contributor

honzatmn commented Jul 1, 2018

@tomashapl Yes

bul-nick-al pushed a commit to bul-nick-al/orbit that referenced this issue Aug 19, 2022
…adding-and-spacing

Simplify Card content padding and spacing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants