-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(Separator): extend description for color prop #3904
Conversation
Size Change: +3 B (0%) Total Size: 482 kB
ℹ️ View Unchanged
|
d2699cb
to
efd2f6b
Compare
Deploying with Cloudflare Pages
|
e0d0f7e
to
6694a0a
Compare
6694a0a
to
a05f410
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the approach can be reconsidered to follow the usual tokens usage, instead of a new one. I left a comment explaining better. WDYT?
Co-authored-by: Daniel Sil <daniel.sil@kiwi.com>
Automatically changed via github action
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just squash commits upon merge 🙏
Extended the docs to make it more clear for users how to use the color prop.
Also extended the typescript templates generation file with generating of palette tokens type.