New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Grid): migrate Grid to tailwind #3965
Conversation
Size Change: +51 B (0%) Total Size: 488 kB
ℹ️ View Unchanged
|
Deploying with Cloudflare Pages
|
1d3a664
to
4304561
Compare
e16dce2
to
ccc739a
Compare
3a89154
to
38d2bb2
Compare
05a54b3
to
96f0981
Compare
57b31dc
to
585d026
Compare
4e1eb7f
to
775033a
Compare
1fcfa52
to
7ac689e
Compare
58fd24b
to
a9342ef
Compare
On first review it looks good 👍 but please rebase and resolve conflicts before I do a final review 🙏 |
585d026
to
f10c145
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a rebase detail
packages/orbit-design-tokens/src/__tests__/__snapshots__/index.test.ts.snap
Outdated
Show resolved
Hide resolved
f10c145
to
6790301
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
* feat(Grid): migrate Grid to tailwind * test: update snapshots * test(Layout): remove maxWidth assetion on Grid * test(Grid): add cypress media-query test
* feat(Grid): migrate Grid to tailwind * test: update snapshots * test(Layout): remove maxWidth assetion on Grid * test(Grid): add cypress media-query test
* feat(Grid): migrate Grid to tailwind * test: update snapshots * test(Layout): remove maxWidth assetion on Grid * test(Grid): add cypress media-query test
* feat(Grid): migrate Grid to tailwind * test: update snapshots * test(Layout): remove maxWidth assetion on Grid * test(Grid): add cypress media-query test
* feat(Grid): migrate Grid to tailwind * test: update snapshots * test(Layout): remove maxWidth assetion on Grid * test(Grid): add cypress media-query test
* feat(Grid): migrate Grid to tailwind * test: update snapshots * test(Layout): remove maxWidth assetion on Grid * test(Grid): add cypress media-query test
* feat(Grid): migrate Grid to tailwind * test: update snapshots * test(Layout): remove maxWidth assetion on Grid * test(Grid): add cypress media-query test
FEPL-1669
I decided not to increase the test coverage for this component, we had it tested with a snapshot and I just added testing for max-width and media-queries in Cypress as we did it for other components that have media-query props.
Perhaps this component will be completely removed after we will start moving our components API more friendly towards Tailwind. So I do not see much sense in adding more tests to it.
Storybook: https://orbit-mainframev-tw-migrate-grid.surge.sh