Folder restructuring #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaroslav-kubicek
approved these changes
Mar 12, 2018
| @@ -1,27 +1,48 @@ | |||
| { | |||
| "name": "kiwi-ui", | |||
| "version": "0.0.0", | |||
| "name": "@kiwicom/balkan-ui", | |||
There was a problem hiding this comment.
why is it still kiwicom/balkan-ui?
There was a problem hiding this comment.
Renaming is part of #73
| In case you want to develop in your current project: | ||
|
|
||
| * `yarn add @kiwicom/balkan-ui` | ||
| * `yarn watch` in this folder |
There was a problem hiding this comment.
I would recommend slightly better notation here, e.g. in this folder => in the root dir of this project
|
@jaroslav-kubicek I have many improvements as well, but the aim of this PR is only the restructuring with as small changes as possible. Everything else can be built on top of it. |
This was referenced Mar 12, 2018
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request meets the following criteria:
Closes #56