-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] record_mode set via vcr_config fixture and marker not honored by block_network #68
Comments
Hi, Thank you for your detailed report! I think that there are two related things. First, the Second, the |
…` mark when `block_network` is applied Ref: #68
…` mark when `block_network` is applied Ref: #68
…` mark when `block_network` is applied Ref: #68
The fix is released in |
Works like a charm, thank you for the quick reaction and fix! 👍 Already planned to vendor a custom block_network as a quickfix(aka the cobblestones to hell 😄 ), which thankfully is now avoided. |
Great to hear that! :) Feel free to reach out to me if there are any other issues with |
Describe the bug
Setting the
record_mode
via config fixture nor marker is not honored by block_network. The record_mode variable in block_network is still in default state"none"
.To Reproduce
Expected behavior
Shouldn't raise a
RuntimeError
since we are supposed to be recording.Environment (please complete the following information):
The text was updated successfully, but these errors were encountered: