This repository has been archived by the owner on Mar 4, 2019. It is now read-only.
Fix: Text component cascades styles #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for kiwicom-universal-components ready! Built with commit ce7d1c6 https://deploy-preview-199--kiwicom-universal-components.netlify.com |
RobinCsl
force-pushed
the
fix/text-styles-should-cascade
branch
from
644c4a9
to
ca2fd14
Compare
tbergquist-godaddy
previously approved these changes
Jan 22, 2019
FilipMessa
reviewed
Jan 22, 2019
| - undefined, | ||
| - undefined, | ||
| - undefined, | ||
| - undefined, |
There was a problem hiding this comment.
probably will be nice have there some values instead of undefined
There was a problem hiding this comment.
Okay, I will improve the implementation to avoid these undefined from popping up.
Summary: To extend React Native's Text component, we should allow styles to cascade. This behaviour was prevented because default values ewere set for the size, the weight and the type. Closes #198
RobinCsl
force-pushed
the
fix/text-styles-should-cascade
branch
from
ca2fd14
to
ce7d1c6
Compare
|
@FilipMessa It should be better now 🙂 |
FilipMessa
approved these changes
Jan 22, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: To extend React Native's Text component, we should allow styles to cascade. This behaviour was prevented because default values ewere set for the size, the weight and the type.
Closes #198