Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REQ_METHOD=POST is ignored #142

Closed
tompittson opened this issue Sep 22, 2021 · 1 comment · Fixed by #143
Closed

REQ_METHOD=POST is ignored #142

tompittson opened this issue Sep 22, 2021 · 1 comment · Fixed by #143
Labels
bug Something isn't working
Milestone

Comments

@tompittson
Copy link

In sidecar.py the request method is retrieved from the environment on this line (54) in sidecar.py:

method = os.getenv(REQ_METHOD)

But later in the same function the variable is overwritten with the METHOD environment variable on line 80 before it is passed to either the list_resources or watch_for_changes functions:

method = os.getenv(METHOD)

This means the value always defaults to GET and you cannot specify using POST with the REQ_METHOD environment variable.

@jekkel jekkel added the bug Something isn't working label Sep 23, 2021
jekkel added a commit that referenced this issue Sep 23, 2021
minor variable name refactoring and fixing duplicate variable usage
@jekkel jekkel mentioned this issue Sep 23, 2021
jekkel added a commit that referenced this issue Sep 23, 2021
@jekkel jekkel added this to the 1.14.1 milestone Sep 23, 2021
@jekkel
Copy link
Member

jekkel commented Sep 23, 2021

Thanks @tompittson for the report, v1.14.1 should fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants