Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(keycloak): upgrade keycloak from 9 to 11 #24

Merged
merged 1 commit into from
Aug 3, 2020

Conversation

patrickleet
Copy link
Contributor

BREAKING CHANGE: Major version change of Keycloak

@patrickleet
Copy link
Contributor Author

@patrickleet
Copy link
Contributor Author

I did not test this manually, just let CI run

@monotek monotek requested a review from rpahli May 11, 2020 14:40
@patrickleet
Copy link
Contributor Author

any updates on this @rpahli?

@axdotl
Copy link
Contributor

axdotl commented Jun 5, 2020

Hi @patrickleet, we're thinking about how to verify that this and upcoming changes of keycloak major versions will be downward compatible. So we've to create an integration test setup which allows us to test with different keycloak versions.
That's why we're currently slow on this issue.

@patrickleet
Copy link
Contributor Author

No worries - using 9 for now - thanks for the project! I'm subscribed to the issue :)

@patrickleet
Copy link
Contributor Author

any updates @axdotl ?

@monotek
Copy link
Contributor

monotek commented Aug 2, 2020

@axdotl is not working for @kiwigrid anymore.
I guess we have to wait for @rpahli to jump in.

@monotek monotek mentioned this pull request Aug 2, 2020
@monotek
Copy link
Contributor

monotek commented Aug 2, 2020

@patrickleet
I've started to implement some tests in #27.
Needs some work though.
Could yo uplease rebase and update to keycloak 11?

@patrickleet patrickleet changed the title feat(keycloak): upgrade keycloak from 9 to 10 feat(keycloak): upgrade keycloak from 9 to 11 Aug 2, 2020
@patrickleet
Copy link
Contributor Author

rebased and updated! I see lot's of new tests, good job!

@monotek
Copy link
Contributor

monotek commented Aug 2, 2020

Damn, i forgot that we can't use docker secrets in pull requests :/
Have to look for a workaround and also improve the last test...

@monotek
Copy link
Contributor

monotek commented Aug 2, 2020

@patrickleet pat

I've fixed the docker problem.
Please rebase again.

I talk to @rpahli tomorrow, if we want to test other stuff too...

BREAKING CHANGE: Major version change of Keycloak

feat: keycloak 11.0.0
@patrickleet
Copy link
Contributor Author

@monotek done

Copy link

@rpahli rpahli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@monotek monotek merged commit c59c57e into kiwigrid:master Aug 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants