You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Add new methods to DropwizardConnectors that make it easy to get port information for application, admin, or all connectors.
These methods can assume (and therefore require) that the ServerFactory be a io.dropwizard.core.server.DefaultServerFactory. This restriction should be documented.
Users should be able to supply an io.dropwizard.core.Configuration or a io.dropwizard.core.server.DefaultServerFactory, which implies method overloads.
Methods that accept a Configuration should be designed such that we could change the implementation to handle both DefaultServerFactory and io.dropwizard.core.server.SimpleServerFactory it it ever becomes necessary. In that case, we could add more methods that mirror the existing ones, but which accept SimpleServerFactory and always return Port instances that have org.kiwiproject.registry.model.PortType of APPLICATION (since SimpleServerFactory only permits a single application port). The methods accepting Configuration could then be refactored to delegate to the appropriate methods based on the ServerFactory type.
The text was updated successfully, but these errors were encountered:
Add several utility methods to get application and/or admin ports from either a Dropwizard
Configuration or DefaultServerFactory.
Also, add scheme() method to ConnectoType enum to get the scheme (http or https).
Closes#450Closes#453
Add new methods to
DropwizardConnectors
that make it easy to get port information for application, admin, or all connectors.These methods can assume (and therefore require) that the
ServerFactory
be aio.dropwizard.core.server.DefaultServerFactory
. This restriction should be documented.Users should be able to supply an
io.dropwizard.core.Configuration
or aio.dropwizard.core.server.DefaultServerFactory
, which implies method overloads.Methods that accept a
Configuration
should be designed such that we could change the implementation to handle bothDefaultServerFactory
andio.dropwizard.core.server.SimpleServerFactory
it it ever becomes necessary. In that case, we could add more methods that mirror the existing ones, but which acceptSimpleServerFactory
and always returnPort
instances that haveorg.kiwiproject.registry.model.PortType
ofAPPLICATION
(sinceSimpleServerFactory
only permits a single application port). The methods acceptingConfiguration
could then be refactored to delegate to the appropriate methods based on theServerFactory
type.The text was updated successfully, but these errors were encountered: