Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump jackson-bom from 2.14.2 to 2.15.0 #655

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Apr 25, 2023

Bumps jackson-bom from 2.14.2 to 2.15.0.

Commits
  • 2c28e23 [maven-release-plugin] prepare release jackson-bom-2.15.0
  • 35c5c4f Prepare for 2.15.0 release
  • 3fc3624 Back to snapshot deps
  • 246b73c [maven-release-plugin] prepare for next development iteration
  • c2b35ab [maven-release-plugin] prepare release jackson-bom-2.15.0-rc3
  • 814d8f5 Prepare for 2.15.0-rc3 release
  • 365ee6a Back to snapshot deps
  • 2ff14f1 [maven-release-plugin] prepare for next development iteration
  • 78c68bc [maven-release-plugin] prepare release jackson-bom-2.15.0-rc2
  • 9f26bd4 Prepare for 2.15.0-rc2
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [jackson-bom](https://github.com/FasterXML/jackson-bom) from 2.14.2 to 2.15.0.
- [Release notes](https://github.com/FasterXML/jackson-bom/releases)
- [Commits](FasterXML/jackson-bom@jackson-bom-2.14.2...jackson-bom-2.15.0)

---
updated-dependencies:
- dependency-name: com.fasterxml.jackson:jackson-bom
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added dependencies Dependency updates java Pull requests that update Java code labels Apr 25, 2023
@sleberknight
Copy link
Member

Among other things, this updates snakeyaml to 2.0.0 (which fixes a CVE). Also see the separate PR #584 which updates snakeyaml.

This should be tested in concert with the snakeyaml update against some (or all) of our projects before merging. Marking as Draft for now.

@sleberknight sleberknight marked this pull request as draft April 27, 2023 18:42
@sleberknight
Copy link
Member

sleberknight commented Apr 30, 2023

After running this against all our repositories, I found only one issue, which was in registry-aware-jersey-client, specifically in DropwizardClientsTest.AddJacksonMessageBodyProvider#shouldDeserializeJsonResponses. After some investigation it was caused by a change in Jackson because of Discrepancy in deserialization of ZonedDateTime and its associated fix in Normalize zone id during ZonedDateTime deserialization.

Once we update to Jackson 2.15.0 the above-mentioned test will fail, with the AssertJ error message:

org.opentest4j.AssertionFailedError: 
expected: DropwizardClientsTest.Person(id=42, firstName=Alice, lastName=Smith, email=alice.smith@gmail.com, age=42, createdAt=2020-03-31T12:00Z[UTC], updatedAt=2020-11-15T14:30Z[UTC])
 but was: DropwizardClientsTest.Person(id=42, firstName=Alice, lastName=Smith, email=alice.smith@gmail.com, age=42, createdAt=2020-03-31T12:00Z, updatedAt=2020-11-15T14:30Z)
Expected :DropwizardClientsTest.Person(id=42, firstName=Alice, lastName=Smith, email=alice.smith@gmail.com, age=42, createdAt=2020-03-31T12:00Z[UTC], updatedAt=2020-11-15T14:30Z[UTC])
Actual   :DropwizardClientsTest.Person(id=42, firstName=Alice, lastName=Smith, email=alice.smith@gmail.com, age=42, createdAt=2020-03-31T12:00Z, updatedAt=2020-11-15T14:30Z)

The specific problem is that the deserialized objects have date/time values such as 2020-03-31T12:00Z[UTC] while the expected ones have values like 2020-03-31T12:00Z. It's always a problem with certificates or time zones... 😄

One way to fix the test is to do this when creating the "expected" Person objects is to change the ZoneId.of("UTC") to ZoneOffset.UTC. Then the tests pass. Note that we cannot make this change until we update Jackson, because using ZoneOffset.UTC fails with Jackson 2.14.x.

Also see these references:

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github May 16, 2023

Superseded by #672.

@dependabot dependabot bot closed this May 16, 2023
@dependabot dependabot bot deleted the dependabot/maven/com.fasterxml.jackson-jackson-bom-2.15.0 branch May 16, 2023 23:59
sleberknight added a commit to kiwiproject/registry-aware-jersey-client that referenced this pull request Jul 24, 2023
* Normalize the ZoneId so the test passes
* Remove Slf4j annotation at top-level since not being used

See the following for more details on the ZoneId issue:
kiwiproject/kiwi-bom#655 (comment)

Closes #259
sleberknight added a commit to kiwiproject/registry-aware-jersey-client that referenced this pull request Jul 25, 2023
* Bump org.kiwiproject:kiwi-bom from 1.0.0 to 1.1.0

Bumps [org.kiwiproject:kiwi-bom](https://github.com/kiwiproject/kiwi-bom) from 1.0.0 to 1.1.0.
- [Release notes](https://github.com/kiwiproject/kiwi-bom/releases)
- [Commits](kiwiproject/kiwi-bom@v1.0.0...v1.1.0)

---
updated-dependencies:
- dependency-name: org.kiwiproject:kiwi-bom
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

* Fix test that breaks in Jackson 2.15.x and higher

* Normalize the ZoneId so the test passes
* Remove Slf4j annotation at top-level since not being used

See the following for more details on the ZoneId issue:
kiwiproject/kiwi-bom#655 (comment)

Closes #259

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Scott Leberknight <174812+sleberknight@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Dependency updates java Pull requests that update Java code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants