Fetch Kiwi TCMS' CA certificate and install it locally during testing #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atodorov
force-pushed
the
document_ssl_certificate_location_config
branch
3 times, most recently
from
1fb42de
to
24debc4
Compare
atodorov
force-pushed
the
document_ssl_certificate_location_config
branch
3 times, most recently
from
a1fb800
to
7f35307
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
atodorov
force-pushed
the
document_ssl_certificate_location_config
branch
5 times, most recently
from
544447c
to
e48a811
Compare
atodorov
force-pushed
the
document_ssl_certificate_location_config
branch
from
e48a811
to
8ffdd6a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #65 +/- ##
=======================================
Coverage 76.56% 76.56%
=======================================
Files 4 4
Lines 320 320
=======================================
Hits 245 245
Misses 75 75 ☔ View full report in Codecov by Sentry. |
atodorov
force-pushed
the
document_ssl_certificate_location_config
branch
from
8ffdd6a
to
68489d9
Compare
that should allow Python to verify the HTTPS certificate on the other side of the connection and not complain about it!
atodorov
force-pushed
the
document_ssl_certificate_location_config
branch
from
68489d9
to
8c5b816
Compare
however this won't go into official documentation because it is not a supported method of consuming Kiwi TCMS, users should always have valid SSL certificates. Closes #56
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
that should allow Python to verify the HTTPS certificate on the other side of the connection and not complain about it!