Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respec configuration as arguments to the TCMS() class #79

Merged
merged 3 commits into from
Apr 26, 2024

Conversation

atodorov
Copy link
Member

example:

TCMS("https://kiwitcms.example.com/xml-rpc/", "api-bot", "keep-me-secret")

this should give more flexibility to developers and eliminate reading from the filesystem when dealing entirely with Python.

@atodorov atodorov force-pushed the pass_auth_via_Python_and_ENV branch from e5bd975 to 7a5d3a9 Compare April 26, 2024 17:16
@atodorov atodorov marked this pull request as ready for review April 26, 2024 17:16
tests/krb5/kiwitcms_kerberos/db_init.py Dismissed Show dismissed Hide dismissed
example:

TCMS("https://kiwitcms.example.com/xml-rpc/", "api-bot", "keep-me-secret")

this should give more flexibility to developers and eliminate reading
from the filesystem when dealing entirely with Python.
@atodorov atodorov force-pushed the pass_auth_via_Python_and_ENV branch 3 times, most recently from f00dcd7 to dc6f5c7 Compare April 26, 2024 18:10
Copy link

codecov bot commented Apr 26, 2024

Codecov Report

Attention: Patch coverage is 78.94737% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 87.53%. Comparing base (924606c) to head (0a454d8).

Files Patch % Lines
tcms_api/__init__.py 78.94% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #79      +/-   ##
==========================================
+ Coverage   78.41%   87.53%   +9.12%     
==========================================
  Files           4        4              
  Lines         315      321       +6     
==========================================
+ Hits          247      281      +34     
+ Misses         68       40      -28     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@atodorov atodorov force-pushed the pass_auth_via_Python_and_ENV branch from dc6f5c7 to bc75548 Compare April 26, 2024 18:40
@atodorov atodorov force-pushed the pass_auth_via_Python_and_ENV branch from bc75548 to 0a454d8 Compare April 26, 2024 20:02
@atodorov atodorov merged commit 7b0ce0e into master Apr 26, 2024
10 checks passed
@atodorov atodorov deleted the pass_auth_via_Python_and_ENV branch April 26, 2024 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant