-
-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suggestion: Option to delete bookmarks with the package #112
Comments
If the the bookmark is attached to the "name" of the ZIM file (and not to the filename, id) then you could reuse these bookmarks at some point with a version with more pictures, or even a more recent version. Maybe we could just "blind" them? |
Hiding the bookmarks of a deleted package would be the minimal solution IMHO. Personally I'd prefer to have the choice between keeping and deleting the bookmarks. |
@martin8032, when you add a bookmark, the bookmark it tied to a package (aka book / zim file), since the bookmark relies on resources in it's package to be loaded. If the kiwix app only have add / remove bookmark function, it wouldn't be very useful. Since when a new version of the package is released, user is gonna replace old package with a new one. All bookmarks tied with the old package will no longer work. To address this issue, we added "name" field to zim files. The "name" is an identifier that is persistent between releases of the same package (e.g. wikimed_nopic, etc.) When a new zim file is added, the "name" field allow the app to check if bookmarks of a older version could be migrated. That's the idea. All issue related to bookmark will be properly addressed in a next major release (for example, 1.10). When the time comes, we will have ability to manage bookmarks by tags or folders, apply different filters to bookmarks, delete package only / bookmark of that package only / both, export bookmark database as a file, backup bookmark using iCloud, etc. But before all these features are added, we have to make it worthwhile to spend the effort bookmarking stuff and to manage a collection of articles. And a great way to start that is to provide ability to migrate old bookmark to the newer package. The upcoming major release (1.9) is not going to address anything related with bookmarks. I am going to improve on what we already have and try to make it as stable and as bug free as possible. |
OK, thank you for this background information. |
This issue has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions. |
No action is planned to be taken from this ticket. Thanks for the suggestions |
I don't see the point in keeping bookmarks for a package that does not exist anymore on the device. But since this is the standard behaviour currently («Delete File: This will delete the zim file but keep the bookmarks.») there may be reasons for this.
So I would suggest that we implement at least an option «Delete bookmarks for this package as well». Because if you prefer clean bookmarks (like I do), deleting them one by one is not a real alternative.
The text was updated successfully, but these errors were encountered: