Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proper handling of UI languages #603

Closed
kelson42 opened this issue Dec 25, 2023 · 5 comments · Fixed by #605
Closed

Proper handling of UI languages #603

kelson42 opened this issue Dec 25, 2023 · 5 comments · Fixed by #605
Assignees
Milestone

Comments

@kelson42
Copy link
Contributor

kelson42 commented Dec 25, 2023

Kiwix is now able to handle many languages and the syncrhonisation with Translatewiki has been achieved. But it is still important that the "correct" language is chosen to display the UI:

  • Custom apps
    • enforced_lang lang is specified in the info.json
      • UI language should not be customizable (in the OS - but app related - settings)
      • UI language should be the one specified in info.json
    • Otherwise works like the Kiwix app
  • Kiwix app

This is valid for iOS and macOS.

@kelson42
Copy link
Contributor Author

@BPerlakiH Do you confirm this is clear? This makes sense? Does it already works like this?

@rgaudin
Copy link
Member

rgaudin commented Dec 27, 2023

there is no such thing as app préf in OS for macOS. It's only iOS

@kelson42
Copy link
Contributor Author

there is no such thing as app préf in OS for macOS. It's only iOS

Then, no way to configure the UI language for the moment. I have open an other ticket for this enhancement (not a priority for the moment).

@BPerlakiH
Copy link
Collaborator

BPerlakiH commented Dec 28, 2023

Thank you @kelson42 it makes sense.
This really means we should include only the enforced language in the custom app.
I will reflect these changes in the latest release.

@BPerlakiH
Copy link
Collaborator

I've created the releases for DWDS app 2023.12.3 (build 133) to reflect these changes, and created a PR to revert the unnecessary changes in the main repo: #605

The project level (automatic) handling of the enforced language will be included on the kiwix-apple-custom repo side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: DONE
3 participants