Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove default/enforced language code solution #605

Merged
merged 2 commits into from
Dec 30, 2023

Conversation

BPerlakiH
Copy link
Collaborator

@BPerlakiH BPerlakiH commented Dec 29, 2023

The problem as of #603

Our former assumption was that if a language is enforced for a custom app, we need to force its selection from the available list of languages, to be the default one.

This assumption is no longer true.

What we want to do instead, is that if a language is enforced for a custom app, we only include this single language, and no other languages can be selected for this app. This means that we can handle this change on the project level, and no code change is required.

Solution

Remove the former changes in code, as they are no longer needed.

@kelson42
Copy link
Contributor

@BPerlakiH Thank you. If it full fixes #603,lease write "Fixes #603" in the PR description. As PR title, please only write a synthetix description of what the PR does (so no related issue number).

@BPerlakiH BPerlakiH changed the title #603 remove default/enforced language code solution Remove default/enforced language code solution Dec 29, 2023
@BPerlakiH
Copy link
Collaborator Author

Thank you, I have updated the PR title, pushed a fix for the CI build.
This PR is not directly solving the issue, the solution comes from the project file settings of the custom app (which is not part of the Kiwix/main). This PR is removing the unnecessary code that was introduced earlier for handling the language settings, which we no longer need.

@kelson42
Copy link
Contributor

@BPerlakiH If i get it right, if we merge only this we will create actually a regression. So in which PR comes the full fix?

@BPerlakiH
Copy link
Collaborator Author

@kelson42 it won't cause a regression, as the solution to the problem is to include only the German language file in the DWDS app settings, which is outside of this repository. It's OK to merge this.

@kelson42 kelson42 merged commit cd1c730 into main Dec 30, 2023
4 checks passed
@kelson42 kelson42 deleted the 603-proper-handling-of-ui-languages branch December 30, 2023 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proper handling of UI languages
2 participants