Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish snapshot on maven for testing the java-libkiwix #52

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

MohitMaliFtechiz
Copy link
Collaborator

Fixes #49

@MohitMaliFtechiz MohitMaliFtechiz marked this pull request as draft July 24, 2023 13:14
@codecov
Copy link

codecov bot commented Jul 24, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (f561034) 92.38% compared to head (4751ef1) 92.38%.

Additional details and impacted files
@@            Coverage Diff            @@
##               main      #52   +/-   ##
=========================================
  Coverage     92.38%   92.38%           
  Complexity      213      213           
=========================================
  Files            44       44           
  Lines           289      289           
  Branches          3        3           
=========================================
  Hits            267      267           
  Misses           19       19           
  Partials          3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

* Introduce publish_snapshot.yml for uploading the snapshot artifact on the mavenCentral.
* We have added the `SNAPSHOT` env variable in publish_snapshot.yml and match it our code if found then it means this workflow triggered to publish the snapshot on maven so on behalf of this we have rectify our code.
@kelson42
Copy link
Contributor

kelson42 commented Aug 16, 2023

@MohitMaliDeveloper Can you please put a status here?

@MohitMaliFtechiz
Copy link
Collaborator Author

@kelson42, Our staging profile id has no access to upload the snapshot on the nexus, we only have access to upload the release artifact on the nexus. There is no option to create a snapshot repo ourselves (Apart from the offline manager) so I have searched over the internet for the official docs and other articles take me to this URL https://www.sonatype.com/products/sonatype-nexus-pro/trial, IMO it is a pro pannel for nexus management but I not sure there will an option to create staging profile there since there is no much information available. Apart from this one article suggested creating a Jira ticket for this and IMO it would be more appropriate to ask them, what should do at this point, or might be, by default snapshots are disabled on our staging profile id which they will enable after creating the ticket.

@kelson42
Copy link
Contributor

@MohitMaliDeveloper OK, lets put side aside for the moment. Either we get somehow these snapshots activated or we should extend the README to explain how to use the latest dev version

@MohitMaliFtechiz
Copy link
Collaborator Author

@MohitMaliDeveloper OK, lets put side aside for the moment. Either we get somehow these snapshots activated

@kelson42 We can create a Jira ticket on SonaType and ask them to activate the snapshot for our stagging profile.

We should extend the README to explain how to use the latest dev version.

Currently java-libkiwix is mainly used for kiwix-android but it can be use for java programs #50 (comment), and most of the IDE now using the gradle build system e.g. Android Studio, Intellij.

For building the binary(generating aar file) instructions are already mentioned in the README.md file so we need to mention how devs can use that aar file in their projects with Gradle.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upload a "dev" version to Maven Central
3 participants