Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add swipe gesture to switch tabs #1113

Closed
abdulwd opened this issue Mar 22, 2019 · 8 comments · Fixed by #1714
Closed

Add swipe gesture to switch tabs #1113

abdulwd opened this issue Mar 22, 2019 · 8 comments · Fixed by #1714
Milestone

Comments

@abdulwd
Copy link
Contributor

abdulwd commented Mar 22, 2019

Is your feature request related to a problem? Please describe.
Tab switching must be easier.

Describe the solution you'd like
Google Chrome offers a great way to switch tabs by horizontally swiping the toolbar. This gesture should be added.

Additional context
ezgif-1-c045626485ed

@abdulwd abdulwd added the UI label Mar 22, 2019
@abdulwd abdulwd added this to the 3.0 milestone Mar 22, 2019
@prajurock
Copy link
Contributor

I want to take the issue but multi zim is supported?

@sauravchandra
Copy link

It would be a nice UI enhancement. I would like to work on it.

@sonusourav
Copy link
Contributor

sonusourav commented Mar 23, 2019

@abdulwd We can use Horizontal swipe gesture to do this.

@abdulwd
Copy link
Contributor Author

abdulwd commented Mar 23, 2019

@prajurock Multi zim is not supported but we can switch between different tabs of the same zim file as done using the tabs switcher. You can work on this issue.

@sonusourav Horizontal swipe gesture is to be added only to the toolbar so that the tabs are not changed by mistake.

@sonusourav
Copy link
Contributor

@abdulwd I too meant the same, horizontal swipe gesture for the toolbar not anywhere else.

@abdulwd
Copy link
Contributor Author

abdulwd commented Mar 23, 2019

@sonusourav I have updated the issue description to make it clear.

@stale
Copy link

stale bot commented Jun 26, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.

@stale stale bot added the stale label Jun 26, 2019
@kelson42 kelson42 modified the milestones: 3.0, 3.1 Jul 29, 2019
@stale stale bot removed the stale label Jul 29, 2019
@kelson42 kelson42 modified the milestones: 3.1, 3.2 Sep 17, 2019
@stale
Copy link

stale bot commented Nov 16, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.

@stale stale bot added the stale label Nov 16, 2019
yashk2000 added a commit to yashk2000/kiwix-android that referenced this issue Jan 26, 2020
yashk2000 added a commit to yashk2000/kiwix-android that referenced this issue Jan 27, 2020
yashk2000 added a commit to yashk2000/kiwix-android that referenced this issue Jan 27, 2020
yashk2000 added a commit to yashk2000/kiwix-android that referenced this issue Jan 27, 2020
yashk2000 added a commit to yashk2000/kiwix-android that referenced this issue Jan 27, 2020
yashk2000 added a commit to yashk2000/kiwix-android that referenced this issue Jan 27, 2020
macgills added a commit that referenced this issue Jan 27, 2020
#1113 Add swipe gesture on the toolbar to switch tabs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants