Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always scroll top and bottom toolbars on webview scrolling (including new navigation bar). #2186

Closed
Frans-Lukas opened this issue Jul 2, 2020 · 0 comments
Closed

Always scroll top and bottom toolbars on webview scrolling (including new navigation bar). #2186

Frans-Lukas opened this issue Jul 2, 2020 · 0 comments
Assignees
@Frans-Lukas
Projects
Frans-Lukas/GSoC

Comments

@Frans-Lukas
Copy link
Contributor

Is your feature request related to a problem? Please describe.

Currently, the top and bottom toolbars are manually scrolled out of view when scrolling in the reader destination. That is, the ToolbarScrollingKiwixWebView translates the pixel-values of the toolbars on scroll. This should be changed to be handled by a coordinator layout instead. The new bottom navigation bar will also be included in this hiding on scroll.

The option of not hiding toolbars on scroll should also be removed. I.e. toolbars will always be hidden on scroll down.

Additional context

This issue is linked with #1611 and when this issue is solved, #1611 should also be solved.
@Frans-Lukas Frans-Lukas self-assigned this Jul 2, 2020
@Frans-Lukas Frans-Lukas added this to In progress in Frans-Lukas/GSoC Jul 2, 2020
Frans-Lukas added a commit to Frans-Lukas/kiwix-android that referenced this issue Jul 3, 2020
@Frans-Lukas
kiwix#2186 top appbar is now scrolling as expected, webview gets stuc…
0c8d3a5 
…k on re-enter
Frans-Lukas added a commit to Frans-Lukas/kiwix-android that referenced this issue Jul 3, 2020
@Frans-Lukas
kiwix#2186 bottom toolbar now works but is slightly off center
08d5c59
Frans-Lukas added a commit to Frans-Lukas/kiwix-android that referenced this issue Jul 6, 2020
@Frans-Lukas
kiwix#2186 scrolling works as expected for top and bottom bars in rea…
e59a3d5 
…der fragment
Frans-Lukas added a commit to Frans-Lukas/kiwix-android that referenced this issue Jul 6, 2020
@Frans-Lukas
kiwix#2186 bottom toolbars icons are now centered
87c2d5b
Frans-Lukas added a commit to Frans-Lukas/kiwix-android that referenced this issue Jul 6, 2020
@Frans-Lukas
kiwix#2186 moved bottom app bar styling to separate style and added t…
c3d6c0c 
…o theme.
Frans-Lukas added a commit to Frans-Lukas/kiwix-android that referenced this issue Jul 6, 2020
@Frans-Lukas
kiwix#2186 removed commented code
1091a25
Frans-Lukas added a commit to Frans-Lukas/kiwix-android that referenced this issue Jul 6, 2020
@Frans-Lukas
kiwix#2186 removed unecessary web views and isHideToolbar preference
a209a2b
@Frans-Lukas Frans-Lukas mentioned this issue Jul 6, 2020
Merged
Frans-Lukas added a commit to Frans-Lukas/kiwix-android that referenced this issue Jul 7, 2020
@Frans-Lukas
kiwix#2186 removed keep bars on scroll preference
ccf54eb
Frans-Lukas added a commit to Frans-Lukas/kiwix-android that referenced this issue Jul 13, 2020
@Frans-Lukas
kiwix#2186 hide bar on scroll works for library and downloads destina…
8ac72ab 
…tions
Frans-Lukas added a commit to Frans-Lukas/kiwix-android that referenced this issue Jul 13, 2020
@Frans-Lukas
kiwix#2186 scrolling works as expected except for reader toolbar bein…
1ace94b 
…g hidden behind navigaiton toolbar
Frans-Lukas added a commit to Frans-Lukas/kiwix-android that referenced this issue Jul 14, 2020
@Frans-Lukas
kiwix#2186 some cleanup
200b8ba
Frans-Lukas added a commit to Frans-Lukas/kiwix-android that referenced this issue Jul 14, 2020
@Frans-Lukas
kiwix#2186 the best current alternative, as fixing the nav to scroll …
0c40020 
…proved to be difficult.
Frans-Lukas added a commit to Frans-Lukas/kiwix-android that referenced this issue Jul 14, 2020
@Frans-Lukas
kiwix#2186 scrolling finally works for reader with two bars
48e6ed2
Frans-Lukas added a commit to Frans-Lukas/kiwix-android that referenced this issue Jul 14, 2020
@Frans-Lukas
kiwix#2186 removed unecessary comment
9935ea3
Frans-Lukas added a commit to Frans-Lukas/kiwix-android that referenced this issue Jul 14, 2020
@Frans-Lukas
kiwix#2186 magin is changed for entire fragment instead of just botto…
a29c9d6 
…m bar
Frans-Lukas added a commit to Frans-Lukas/kiwix-android that referenced this issue Jul 14, 2020
@Frans-Lukas
kiwix#2186 all main destinations now hide toolbars on scroll and fixe…
068277e 
…d snackbar
@Frans-Lukas Frans-Lukas moved this from In progress to In Review in Frans-Lukas/GSoC Jul 14, 2020
Frans-Lukas added a commit to Frans-Lukas/kiwix-android that referenced this issue Jul 15, 2020
@Frans-Lukas
kiwix#2186 removed commented set of scroll position
e90c47d
Frans-Lukas added a commit to Frans-Lukas/kiwix-android that referenced this issue Jul 15, 2020
@Frans-Lukas
kiwix#2186 made ScrollingViewWithBottom.. more readable
8dd5e72
Frans-Lukas added a commit to Frans-Lukas/kiwix-android that referenced this issue Jul 15, 2020
@Frans-Lukas
kiwix#2186 reference to fabian@stackoverflow in nested coordinator la…
b26a299 
…yout
Frans-Lukas added a commit to Frans-Lukas/kiwix-android that referenced this issue Jul 15, 2020
@Frans-Lukas
kiwix#2186 referenced james @ stackoverflow on scrollingViewWith..
0a74c7d
Frans-Lukas added a commit to Frans-Lukas/kiwix-android that referenced this issue Jul 15, 2020
@Frans-Lukas
kiwix#2186 requested fixes
a094840
Frans-Lukas added a commit to Frans-Lukas/kiwix-android that referenced this issue Jul 15, 2020
@Frans-Lukas
kiwix#2186 fixed snackbar not being clickable when multiple open tabs
fb12f6e
Frans-Lukas added a commit to Frans-Lukas/kiwix-android that referenced this issue Jul 16, 2020
@Frans-Lukas
kiwix#2186 merge with feature/navigation
46b7e0d
Frans-Lukas added a commit to Frans-Lukas/kiwix-android that referenced this issue Jul 16, 2020
@Frans-Lukas
kiwix#2186 added topMargin to activity_main_nav_view to show drawer c…
e8bd136 
…orrectly
Frans-Lukas added a commit to Frans-Lukas/kiwix-android that referenced this issue Jul 16, 2020
@Frans-Lukas
kiwix#2186 fixed line length
f7ef36d
Frans-Lukas added a commit to Frans-Lukas/kiwix-android that referenced this issue Jul 17, 2020
@Frans-Lukas
kiwix#2186 dark mode now works with scrolling
068f9ea
Frans-Lukas added a commit to Frans-Lukas/kiwix-android that referenced this issue Jul 17, 2020
@Frans-Lukas
kiwix#2186 made the appbar clickable when the tab view is open.
802cf1c
Frans-Lukas added a commit to Frans-Lukas/kiwix-android that referenced this issue Jul 17, 2020
@Frans-Lukas
kiwix#2186 fixed reader fragment overlapping nav bar some times
3a825af
Frans-Lukas added a commit to Frans-Lukas/kiwix-android that referenced this issue Jul 17, 2020
@Frans-Lukas
kiwix#2186 renamed getColorAttribute and uses it for action bar size
052b855
Frans-Lukas added a commit to Frans-Lukas/kiwix-android that referenced this issue Jul 20, 2020
@Frans-Lukas
kiwix#2186 merge with feature/navigation
67f116c
Frans-Lukas added a commit to Frans-Lukas/kiwix-android that referenced this issue Jul 21, 2020
@Frans-Lukas
kiwix#2186 re-added ToolbarScrollingKiwixWebView
ec8d811
Frans-Lukas added a commit to Frans-Lukas/kiwix-android that referenced this issue Jul 21, 2020
@Frans-Lukas
kiwix#2186 Toolbar scrolling webview now hides navigation bar in read…
391294a 
…erFragment
macgills pushed a commit that referenced this issue Jul 21, 2020
@Frans-Lukas
#2186 progressBar is now hiding when exiting tab switcher, also remov…
5ec3771 
…ed unused string resource
@Frans-Lukas Frans-Lukas moved this from In Review to Done in Frans-Lukas/GSoC Jul 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Frans-Lukas Frans-Lukas

Labels
None yet
Projects
No open projects
Frans-Lukas/GSoC
  
Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Frans-Lukas