-
-
Notifications
You must be signed in to change notification settings - Fork 444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve to 10/10 on Exodus #2859
Comments
@gouri-panda @MohitMaliDeveloper Do you know why we need the permissions |
@gouri-panda thank you for your response. If I refer to https://developer.android.com/reference/android/Manifest.permission, I have:
|
@kelson42 We use WI-FI for hosting zim files and sharing(not transfer) zim files to nearby devices. A successful WI-Fi discovery peer needs these permissions to scan available WI-Fi peers for the purpose of establishing a connection1. But starting from android 13 we can make this go away by adding this permission to our manifest.
But below android 13 we need these permissions. Footnotes |
@MohitMaliFtechiz Maybe you have an explanation to my last question? |
hi @kelson42 , We can only get rid of these permission once we target android 13 and above below we do requires this permission https://developer.android.com/about/versions/13/features/nearby-wifi-devices-permission. We require this permission for Peer to Peer connection https://developer.android.com/guide/topics/connectivity/wifip2p . |
@MohitMaliFtechiz Ok so we should change for android13+. There is no way to require only this permission when this specific feature is used? To avoid a bad note? |
yes currently i have checked we are requesting this permission on runtime when specific feature is used. |
@MohitMaliFtechiz OK. Can you adapt for 13+? |
ok @kelson42 |
This issue has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions. |
@MohitMaliFtechiz Anything stopping us to move forward here? |
Will recheck the not once 3.8 is published on playstore. |
Our assessment on Exodus is 9/10
https://reports.exodus-privacy.eu.org/fr/reports/org.kiwix.kiwixmobile/latest/
I would like to see if we can improve to 10/10
The text was updated successfully, but these errors were encountered: