-
-
Notifications
You must be signed in to change notification settings - Fork 446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Android 13 targeting #2910
Android 13 targeting #2910
Conversation
hi , We have to wait for fetch library to update before closing target android 13, We have to wait until this PR is merged into fetch tonyofrancis/Fetch#626 |
We can not count on this because the development of Fetch is totally stoped since years. Actually I though we use a fork of it?! |
I check fork of Fetch have not found any updated one which is available on public repo store so I have override method of fetch and placed the check that support for android 13 it. |
OK, so this PR is ready to review? Still in draft! |
Codecov Report
@@ Coverage Diff @@
## develop #2910 +/- ##
=============================================
- Coverage 42.32% 41.78% -0.55%
Complexity 25 25
=============================================
Files 299 299
Lines 9367 9459 +92
Branches 948 970 +22
=============================================
- Hits 3965 3952 -13
- Misses 5027 5129 +102
- Partials 375 378 +3
Continue to review full report at Codecov.
|
As we are moving directly from 30 to 33, we need to make sure all the API changes are considered. I suggest you check the SplashScreenApi once and make sure the theme properties match our required behaviour. |
@MohitMaliFtechiz Thanks for this! I'll review it soon :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should also think about adding android 13 to CI.
Related to #2859 , let see if it will fixed it.