Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android 13 targeting #2910

Merged
merged 8 commits into from
Jul 26, 2022
Merged

Android 13 targeting #2910

merged 8 commits into from
Jul 26, 2022

Conversation

MohitMaliFtechiz
Copy link
Collaborator

@MohitMaliFtechiz MohitMaliFtechiz commented Jul 12, 2022

Related to #2859 , let see if it will fixed it.

@MohitMaliFtechiz MohitMaliFtechiz marked this pull request as draft July 12, 2022 13:12
@kelson42 kelson42 changed the title android 13 targeting Android 13 targeting Jul 12, 2022
@MohitMaliFtechiz
Copy link
Collaborator Author

hi ,

We have to wait for fetch library to update before closing target android 13, We have to wait until this PR is merged into fetch tonyofrancis/Fetch#626

@kelson42
Copy link
Collaborator

@MohitMaliFtechiz

We have to wait for fetch library to update before closing target android 13, We have to wait until this PR is merged into fetch tonyofrancis/Fetch#626

We can not count on this because the development of Fetch is totally stoped since years. Actually I though we use a fork of it?!

@MohitMaliFtechiz
Copy link
Collaborator Author

MohitMaliFtechiz commented Jul 15, 2022

I check fork of Fetch have not found any updated one which is available on public repo store so I have override method of fetch and placed the check that support for android 13 it.

@kelson42
Copy link
Collaborator

OK, so this PR is ready to review? Still in draft!

@codecov
Copy link

codecov bot commented Jul 16, 2022

Codecov Report

Merging #2910 (5075bb7) into develop (73db6d0) will decrease coverage by 0.54%.
The diff coverage is 0.85%.

@@              Coverage Diff              @@
##             develop    #2910      +/-   ##
=============================================
- Coverage      42.32%   41.78%   -0.55%     
  Complexity        25       25              
=============================================
  Files            299      299              
  Lines           9367     9459      +92     
  Branches         948      970      +22     
=============================================
- Hits            3965     3952      -13     
- Misses          5027     5129     +102     
- Partials         375      378       +3     
Impacted Files Coverage Δ
...ile/localFileTransfer/LocalFileTransferFragment.kt 23.80% <0.00%> (-2.69%) ⬇️
...le/nav/destination/library/LocalLibraryFragment.kt 45.23% <0.00%> (-3.17%) ⬇️
...org/kiwix/kiwixmobile/webserver/ZimHostFragment.kt 22.47% <0.00%> (-2.79%) ⬇️
...bserver/wifi_hotspot/HotspotNotificationManager.kt 7.14% <0.00%> (-0.97%) ⬇️
...a/org/kiwix/kiwixmobile/core/main/AddNoteDialog.kt 0.00% <0.00%> (ø)
...rg/kiwix/kiwixmobile/core/main/CoreSearchWidget.kt 0.00% <0.00%> (ø)
...kiwix/kiwixmobile/core/utils/dialog/KiwixDialog.kt 26.92% <0.00%> (-0.77%) ⬇️
...wnloader/fetch/FetchDownloadNotificationManager.kt 3.40% <3.57%> (-1.43%) ⬇️
...iwixmobile/language/viewmodel/LanguageViewModel.kt 92.68% <0.00%> (-7.32%) ⬇️
...org/kiwix/kiwixmobile/language/LanguageFragment.kt 68.51% <0.00%> (-5.56%) ⬇️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 73db6d0...5075bb7. Read the comment docs.

@MohitMaliFtechiz MohitMaliFtechiz marked this pull request as ready for review July 16, 2022 06:59
@4shutosh
Copy link
Contributor

As we are moving directly from 30 to 33, we need to make sure all the API changes are considered.

I suggest you check the SplashScreenApi once and make sure the theme properties match our required behaviour.

@gouri-panda
Copy link
Collaborator

@MohitMaliFtechiz Thanks for this! I'll review it soon :)

gouri-panda
gouri-panda previously approved these changes Jul 24, 2022
Copy link
Collaborator

@gouri-panda gouri-panda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also think about adding android 13 to CI.

@kelson42 kelson42 merged commit 609d968 into develop Jul 26, 2022
@kelson42 kelson42 deleted the Issue#2859 branch July 26, 2022 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants