Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redundant Toast pops up even when storage permissions are allowed #978

Closed
vaibhav2000 opened this issue Feb 13, 2019 · 7 comments · Fixed by #1571
Closed

Redundant Toast pops up even when storage permissions are allowed #978

vaibhav2000 opened this issue Feb 13, 2019 · 7 comments · Fixed by #1571

Comments

@vaibhav2000
Copy link
Contributor

vaibhav2000 commented Feb 13, 2019

Describe the bug

When the app starts up, the app asks for permissions to access the storage. Upon pressing "Yes" a toast pops up saying "To access offline content we need access to your storage" which is redundant as permissions have already been given.

Expected behavior

There is no use of this toast to pop up when permissions have been allowed.

Steps to reproduce the behavior:

  1. Open the app for the first time
  2. Press "Yes" on the prompt for storage access permissions
    Screenshots

screenshot_20190213-155709

Environment

  • Version of Kiwix Android : 2.4 Build 55
  • Device : Moto G5 Plus
  • OS version : Android 8.0
@MisterAwesome23
Copy link
Contributor

MisterAwesome23 commented Feb 16, 2019

I would like to enhance this. On it.

@stale
Copy link

stale bot commented Jun 26, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.

@stale stale bot added the stale label Jun 26, 2019
@mhutti1
Copy link
Contributor

mhutti1 commented Aug 16, 2019

I don't think this is problematic enough to warrant changing.

@mhutti1 mhutti1 closed this as completed Aug 16, 2019
@macgills
Copy link
Contributor

macgills commented Aug 20, 2019

I find it pretty annoying and it is a most a one line fix? Also this happens on ZimManageActivity or ZimFileSelectFragment

@macgills macgills reopened this Aug 20, 2019
@stale stale bot removed the stale label Aug 20, 2019
@kelson42 kelson42 added this to the 3.1 milestone Sep 24, 2019
@kelson42
Copy link
Collaborator

@macgills I don't have experienced this problem but if the fix is easy easy it should be done.

@kelson42
Copy link
Collaborator

@abdulwd Would you be able to help us to fix that one?

@abdulwd
Copy link
Contributor

abdulwd commented Oct 23, 2019

@kelson42 I will work on it this weekend. I'm busy with other stuff at the moment. :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants