New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes home screen banner issue #1027
Conversation
There is absolutely no need to add all these resources. Android can downscale images on lower end devices. Remove all the lower resolution images please. That's like a couple of megabytes. |
@abdulwd Could you please review this? |
@sonusourav Please rebase and squash the commits. |
@abdulwd I have rebased and squashed. Could you please review? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a white boundary around the Kiwix logo in the landscape mode which is not there in the portrait mode. I think you can fix that easily.
app/src/main/java/org/kiwix/kiwixmobile/main/KiwixWebViewClient.java
Outdated
Show resolved
Hide resolved
app/src/main/java/org/kiwix/kiwixmobile/main/KiwixWebViewClient.java
Outdated
Show resolved
Hide resolved
app/src/main/java/org/kiwix/kiwixmobile/main/KiwixWebViewClient.java
Outdated
Show resolved
Hide resolved
Could you explain why the extra resources are necessary? |
This issue has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions. |
@sonusourav We would like to carry on with this PR finally. Would you consider to answer @mhutti1 to finish the PR reviewing process? |
This pull request has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions. |
No feedback. Closing the PR. |
Fixes #911
Changes: Used different kiwix logo design to make up for the space in landscape orientation but the main design is kept intact.
Screenshots/GIF for the change: