Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes home screen banner issue #1027

Closed
wants to merge 1 commit into from
Closed

Fixes home screen banner issue #1027

wants to merge 1 commit into from

Conversation

sonusourav
Copy link
Contributor

Fixes #911

Changes: Used different kiwix logo design to make up for the space in landscape orientation but the main design is kept intact.

Screenshots/GIF for the change:
banner fix

@rashiq
Copy link
Contributor

rashiq commented Feb 23, 2019

There is absolutely no need to add all these resources. Android can downscale images on lower end devices. Remove all the lower resolution images please. That's like a couple of megabytes.

@sonusourav
Copy link
Contributor Author

sonusourav commented Feb 24, 2019

@rashiq @soloturn I had put them because they were there before also. But still if you want I would remove them. Could you please be a bit more clear that out of the following dimensions which one to keep:

  1. hdpi
  2. mdpi
  3. xhdpi
  4. xxhdpi
  5. xxxhdpi

@sonusourav
Copy link
Contributor Author

@abdulwd Could you please review this?

@abdulwd
Copy link
Contributor

abdulwd commented Mar 8, 2019

@sonusourav Please rebase and squash the commits.

@sonusourav
Copy link
Contributor Author

@abdulwd I have rebased and squashed. Could you please review?

Copy link
Contributor

@abdulwd abdulwd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a white boundary around the Kiwix logo in the landscape mode which is not there in the portrait mode. I think you can fix that easily.

@mhutti1
Copy link
Contributor

mhutti1 commented Mar 30, 2019

Could you explain why the extra resources are necessary?

@stale
Copy link

stale bot commented Jun 26, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.

@stale stale bot added the stale label Jun 26, 2019
@kelson42
Copy link
Collaborator

@sonusourav We would like to carry on with this PR finally. Would you consider to answer @mhutti1 to finish the PR reviewing process?

@stale stale bot removed the stale label Jul 12, 2019
@kelson42 kelson42 requested a review from mhutti1 July 12, 2019 17:34
@stale
Copy link

stale bot commented Jul 19, 2019

This pull request has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.

@stale stale bot added the stale label Jul 19, 2019
@kelson42
Copy link
Collaborator

No feedback. Closing the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants