-
-
Notifications
You must be signed in to change notification settings - Fork 443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes many Codefactor issues #3343
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #3343 +/- ##
=============================================
+ Coverage 48.44% 49.00% +0.56%
- Complexity 993 1002 +9
=============================================
Files 284 284
Lines 9950 9949 -1
Branches 1314 1314
=============================================
+ Hits 4820 4876 +56
+ Misses 4369 4303 -66
- Partials 761 770 +9
☔ View full report in Codecov by Sentry. |
@shashank-0-0 Please avoid to open new PR in the future, this just makes things more complex, and considering you have full control with your PR, you can anyway do whatever you want on it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shashank-0-0 Thanks for your PR 🎉 🎉 @kelson42 it's LGTM.
My bad , i was unaware of the interactive rebase feature i could have used to remove commits, |
Fixes #3318
Previous PR #3323
@MohitMaliFtechiz @kelson42 This can be reviewed
I made a new PR because the previous one had unnecessary commits which had very minor changes.