Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes many Codefactor issues #3343

Merged
merged 2 commits into from
May 24, 2023
Merged

Conversation

shashank-0-0
Copy link
Contributor

@shashank-0-0 shashank-0-0 commented May 24, 2023

Fixes #3318
Previous PR #3323

@MohitMaliFtechiz @kelson42 This can be reviewed

I made a new PR because the previous one had unnecessary commits which had very minor changes.

@codecov
Copy link

codecov bot commented May 24, 2023

Codecov Report

Patch coverage: 75.00% and project coverage change: +0.56 🎉

Comparison is base (f474cc2) 48.44% compared to head (3020ed0) 49.00%.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #3343      +/-   ##
=============================================
+ Coverage      48.44%   49.00%   +0.56%     
- Complexity       993     1002       +9     
=============================================
  Files            284      284              
  Lines           9950     9949       -1     
  Branches        1314     1314              
=============================================
+ Hits            4820     4876      +56     
+ Misses          4369     4303      -66     
- Partials         761      770       +9     
Impacted Files Coverage Δ
...rg/kiwix/kiwixmobile/webserver/ZimHostPresenter.kt 68.42% <0.00%> (ø)
.../java/org/kiwix/kiwixmobile/core/JNIInitialiser.kt 47.36% <ø> (ø)
.../kiwix/kiwixmobile/core/main/CoreReaderFragment.kt 37.23% <0.00%> (+0.29%) ⬆️
...iwix/kiwixmobile/core/main/OnSwipeTouchListener.kt 25.00% <ø> (+1.47%) ⬆️
...mobile/core/page/history/viewmodel/HistoryState.kt 76.92% <0.00%> (ø)
...org/kiwix/kiwixmobile/intro/CustomPageIndicator.kt 87.65% <100.00%> (ø)
...kiwix/kiwixmobile/core/downloader/model/Seconds.kt 59.09% <100.00%> (ø)
...ile/core/search/viewmodel/SearchResultGenerator.kt 89.47% <100.00%> (+0.58%) ⬆️
...org/kiwix/kiwixmobile/core/zim_manager/KiloByte.kt 85.71% <100.00%> (ø)
...ager/fileselect_view/adapter/BookOnDiskDelegate.kt 100.00% <100.00%> (ø)
... and 1 more

... and 9 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kelson42
Copy link
Collaborator

@shashank-0-0 Please avoid to open new PR in the future, this just makes things more complex, and considering you have full control with your PR, you can anyway do whatever you want on it.

Copy link
Collaborator

@MohitMaliFtechiz MohitMaliFtechiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shashank-0-0 Thanks for your PR 🎉 🎉 @kelson42 it's LGTM.

@shashank-0-0
Copy link
Contributor Author

@shashank-0-0 Please avoid to open new PR in the future, this just makes things more complex, and considering you have full control with your PR, you can anyway do whatever you want on it.

My bad , i was unaware of the interactive rebase feature i could have used to remove commits,
i will not open multiple Pr's next time

@kelson42 kelson42 changed the title Fixing issue 3318 Fixes many Codefactor issues May 24, 2023
@kelson42 kelson42 merged commit 1d386b8 into kiwix:develop May 24, 2023
10 checks passed
@shashank-0-0 shashank-0-0 deleted the fixing-issue-3318 branch June 2, 2023 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Codefactor issues
3 participants