Fixed the redundancy of the 'All-Books-Mode' option for Bookmarks, Notes, and History in custom apps. #3525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MohitMaliFtechiz
force-pushed
the
Issue#3523
branch
from
9504bfe
to
fc5817d
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #3525 +/- ##
=============================================
+ Coverage 49.15% 49.21% +0.06%
+ Complexity 1075 1072 -3
=============================================
Files 285 285
Lines 10365 10334 -31
Branches 1382 1378 -4
=============================================
- Hits 5095 5086 -9
+ Misses 4451 4431 -20
+ Partials 819 817 -2
☔ View full report in Codecov by Sentry. |
…tes, and History in custom apps. * Since custom apps only have a single zim file, there is no need to display these switches, which can potentially confuse users. Therefore, we have hidden these switches in custom apps.
|
Merging unfortunately without any review :( |
|
@kelson42 @MohitMaliDeveloper I'll review/test this. I'll open a ticket if I'll find something. |
gouri-panda
reviewed
Nov 12, 2023
There was a problem hiding this comment.
@kelson42 @MohitMaliDeveloper Looks good to me! We should have add some tests for this since it's some vital code in the main app.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3523
Since custom apps only have a single zim file, there is no need to display these switches, which can potentially confuse users. Therefore, we have hidden these switches in custom apps.
Custom apps
customappsswitches.mp4
Kiwix App
kiwixappswitches.mp4