Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgraded webkit version to latest to work with latest chromium dependencies. #3648

Merged
merged 1 commit into from
Jan 3, 2024

Conversation

MohitMaliFtechiz
Copy link
Collaborator

Fixes #3644

  • Upgraded the WebKit version to the latest (from 1.3.0 to 1.7.0) to leverage improvements and bug fixes. This update is essential to address the issue with the latest chromium dependency, as outlined in ExceptionInInitializerError reported by the play store #3644.
  • Additionally, elevated the androidx.annotation:annotation dependency from 1.1.0 to 1.2.0 to meet the requirements of the updated WebKit version.

…ndencies.

* Upgraded the `WebKit` version to the latest (from 1.3.0 to 1.7.0) to leverage improvements and bug fixes. This update is essential to address the issue with the latest `chromium` dependency, as outlined in #3644.
* Additionally, elevated the `androidx.annotation:annotation` dependency from `1.1.0` to `1.2.0` to meet the requirements of the updated WebKit version.
Copy link

codecov bot commented Jan 2, 2024

Codecov Report

Attention: 18 lines in your changes are missing coverage. Please review.

Comparison is base (fff9991) 48.69% compared to head (4796137) 48.64%.
Report is 3 commits behind head on main.

Files Patch % Lines
...kiwix/kiwixmobile/core/utils/dialog/KiwixDialog.kt 0.00% 10 Missing ⚠️
...va/org/kiwix/kiwixmobile/core/help/HelpFragment.kt 33.33% 2 Missing and 2 partials ⚠️
...va/org/kiwix/kiwixmobile/help/KiwixHelpFragment.kt 0.00% 3 Missing ⚠️
...le/nav/destination/library/LocalLibraryFragment.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #3648      +/-   ##
============================================
- Coverage     48.69%   48.64%   -0.06%     
  Complexity     1090     1090              
============================================
  Files           285      285              
  Lines         10564    10573       +9     
  Branches       1415     1417       +2     
============================================
- Hits           5144     5143       -1     
- Misses         4579     4587       +8     
- Partials        841      843       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@gouri-panda gouri-panda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MohitMaliFtechiz We need to change the parameters of the new API.

@MohitMaliFtechiz
Copy link
Collaborator Author

MohitMaliFtechiz commented Jan 2, 2024

@gouri-panda Which new API? Are you talking about updating all the dependencies according to our compiled SDK version?

@gouri-panda
Copy link
Collaborator

@MohitMaliFtechiz For some reason the string files doesn't compile to the recent versions even though we haven't changed here. So I guess the new SDK cause there.

 /home/runner/work/kiwix-android/kiwix-android/core/src/main/res/values-zh-rTW/strings.xml:303: Conflicting number of arguments (0) here

@MohitMaliFtechiz
Copy link
Collaborator Author

MohitMaliFtechiz commented Jan 2, 2024

@gouri-panda Now I got your point.

No, it is not related to the new SDK, We have implemented #3625 after that this error came because the previous translations had been already merged. I already placed a fix for it on translate wiki and some of the strings have already come in the latest translateWiki PR only 2 translations are left to come. Once all the changes are come these errors will automatically gone.

@kelson42
Copy link
Collaborator

kelson42 commented Jan 2, 2024

@MohitMaliFtechiz Do zimit still work properly? It does not i play to stop supporting older versions of Android?

@MohitMaliFtechiz
Copy link
Collaborator Author

@MohitMaliFtechiz Do zimit still work properly? It does not i play to stop supporting older versions of Android?

@kelson42 Yes it is working with Zimit files, I have tested it on Android 8, Android 12, and Android 13.

On Android 8

Screenshot_20211214-143511

On Android 12

ZimitFilesOnAndroid12.mp4

@kelson42 kelson42 merged commit 1c85cc5 into main Jan 3, 2024
7 of 9 checks passed
@kelson42 kelson42 deleted the Fix#3644 branch January 3, 2024 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ExceptionInInitializerError reported by the play store
3 participants