Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#3654 Added valid link for DESIGN.md #3655

Merged
merged 2 commits into from
Jan 5, 2024
Merged

#3654 Added valid link for DESIGN.md #3655

merged 2 commits into from
Jan 5, 2024

Conversation

Sagar0-0
Copy link
Contributor

@Sagar0-0 Sagar0-0 commented Jan 5, 2024

Fixes #3654

Screenshots

MohitMaliFtechiz
MohitMaliFtechiz requested changes Jan 5, 2024
View reviewed changes
Copy link
Collaborator

@MohitMaliFtechiz MohitMaliFtechiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Sagar0-0 Thanks for your PR and for pointing out the bug, There is one more invalid link in the CONTRIBUTING.md file that leads to 404 not found. Can you please fix this invalid link?

kiwix-android/CONTRIBUTING.md

Line 124 in 1c85cc5

learn more about the commands run on the CI please refer to [.github/workflows](https://github.com/kiwix/kiwix-android/tree/develop/.github/workflows).

MohitMaliFtechiz
MohitMaliFtechiz approved these changes Jan 5, 2024
View reviewed changes
Copy link
Collaborator

@MohitMaliFtechiz MohitMaliFtechiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Sagar0-0 Thanks 🎉

@kelson42 kelson42 merged commit 329242e into kiwix:main Jan 5, 2024
4 of 7 checks passed
@Sagar0-0 Sagar0-0 deleted the patch-1 branch January 5, 2024 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MohitMaliFtechiz MohitMaliFtechiz MohitMaliFtechiz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Invalid link for DESIGN.md in CONTRIBUTING.md
3 participants
@Sagar0-0 @MohitMaliFtechiz @kelson42