Fixed: Inconsistent Visibility Behavior: Text and Button Overlay When Opening Tabs. #3688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3688 +/- ##
============================================
+ Coverage 48.54% 48.59% +0.05%
- Complexity 1089 1092 +3
============================================
Files 285 285
Lines 10591 10591
Branches 1422 1422
============================================
+ Hits 5141 5147 +6
+ Misses 4606 4604 -2
+ Partials 844 840 -4 ☔ View full report in Codecov by Sentry. |
gouri-panda
approved these changes
Feb 3, 2024
There was a problem hiding this comment.
@MohitMaliDeveloper Thanks 🎉Code looks goode to me but unfortunately i can't produce this bug. But it makes sense. @kelson42 LGTM!
… Opening Tabs. * Fixed the tab icon showing when there is no ZIM file is opened in the reader which causing the unexpected UI behaviour. * Fixed "Read Aloud" menu item is showing when we close all tabs(which means currently no ZIM file is opened in the reader) so showing this button is redundant.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3623
Before Fix
beforefix.mp4
After Fix
AfterFix.mp4