Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed: Content is not displaying after opening the ZIM file from Chrome. #3727

Merged
merged 1 commit into from
Mar 1, 2024

Conversation

MohitMaliFtechiz
Copy link
Collaborator

Fixes #3726

Although the ZIM file is loaded, it does not appear in the reader because the "Open Library" button is already visible, and the content view is hidden at this point. To address this, we utilized our reopenBook() method when loading the ZIM file in the reader, which manages the visibility of these views.

Before fix

ContentIsNotShowing.mp4

After Fix

ContentNotShowingFixed.mp4

* Although the ZIM file is loaded, it does not appear in the reader because the "Open Library" button is already visible, and the content view is hidden at this point. To address this, we utilized our `reopenBook()` method when loading the ZIM file in reader, which manages the visibility of these views.
Copy link

codecov bot commented Feb 29, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 52.15%. Comparing base (a68e37f) to head (c3f6e50).

Files Patch % Lines
.../kiwix/kiwixmobile/core/main/CoreReaderFragment.kt 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #3727      +/-   ##
============================================
- Coverage     52.18%   52.15%   -0.03%     
+ Complexity     1238     1235       -3     
============================================
  Files           290      290              
  Lines         10908    10910       +2     
  Branches       1459     1459              
============================================
- Hits           5692     5690       -2     
- Misses         4248     4253       +5     
+ Partials        968      967       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kelson42 kelson42 merged commit 0107edd into main Mar 1, 2024
8 of 10 checks passed
@kelson42 kelson42 deleted the Fix#3726 branch March 1, 2024 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Content is not displaying after opening the ZIM file from Chrome.
3 participants