[Fix]: Read aloud will stop on close tab #3745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3745 +/- ##
============================================
+ Coverage 52.07% 52.24% +0.16%
- Complexity 1265 1270 +5
============================================
Files 292 292
Lines 10974 10977 +3
Branches 1451 1454 +3
============================================
+ Hits 5715 5735 +20
+ Misses 4304 4286 -18
- Partials 955 956 +1 ☔ View full report in Codecov by Sentry. |
MohitMaliFtechiz
requested changes
Mar 12, 2024
There was a problem hiding this comment.
@Sagar0-0 Please make changes in this PR according to these two comments #3740 (comment) #3740 (comment)
|
@MohitMaliFtechiz please confirm the final changes. |
MohitMaliFtechiz
requested changes
Mar 13, 2024
There was a problem hiding this comment.
@Sagar0-0 Just a small change, and then we are good to merge.
core/src/main/java/org/kiwix/kiwixmobile/core/main/CoreReaderFragment.kt
Outdated
Show resolved
Hide resolved
MohitMaliFtechiz
approved these changes
Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3740
Used onReadAloudStop method on close tab
Screenshots