Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Implementation issue reported by the playstore. #3814

Merged
merged 1 commit into from
Apr 30, 2024
Merged

Conversation

MohitMaliFtechiz
Copy link
Collaborator

Fixes #3812

  • Changed the width and height of ic_tab_switcher_text to wrapContent instead of fixed width and height which prevents to expansion of the view if there is more content to display.
  • To maintain the current design we have added the minHeight and minWidth for textView otherwise the background was showing very odd.
  • For other issues that are showing in the below screenshots, we can not place a fix for these issues, since these are inside the library and there are no methods for setting the textSize. However, the issue is we need to change the textSize from dp to sp, and it is only show once when this feature is first time used.
    Screenshot from 2024-04-30 18-34-39
    Screenshot from 2024-04-30 18-34-34

* Changed the width and height of `ic_tab_switcher_text` to  `wrapContent`  instead of fixed width and height which prevents to expand of the view if there is more content to display.
* To maintain the current design we have added the `minHeight` and `minWidth` for textView otherwise the background was showing very odd.
Copy link

codecov bot commented Apr 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.12%. Comparing base (281ce6f) to head (471337d).

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #3814      +/-   ##
============================================
- Coverage     53.21%   53.12%   -0.10%     
+ Complexity     1309     1305       -4     
============================================
  Files           292      292              
  Lines         11047    11047              
  Branches       1468     1468              
============================================
- Hits           5879     5869      -10     
- Misses         4192     4198       +6     
- Partials        976      980       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kelson42 kelson42 merged commit c8f080f into main Apr 30, 2024
10 checks passed
@kelson42 kelson42 deleted the Fix#3812 branch April 30, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implementation issue reported by the playstore.
3 participants