Fixed: issue with front page of Zim on a USB stick loading. #3817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3817 +/- ##
============================================
+ Coverage 53.14% 53.33% +0.19%
- Complexity 1306 1319 +13
============================================
Files 292 292
Lines 11062 11060 -2
Branches 1471 1471
============================================
+ Hits 5879 5899 +20
+ Misses 4202 4190 -12
+ Partials 981 971 -10 ☔ View full report in Codecov by Sentry. |
|
@MohitMaliDeveloper Is this PR still a draft? |
* Rectified the `ServiceWorkerUninitialiser` code to appropriately uninitialize the service worker. Previously, when the uninitializing code ran from the JavaScript interface, we directly called the function, which sometimes functioned correctly but sometimes did not. To address this inconsistency, we are now invoking that function to ensure the main page loads after the service worker is uninitialized. * Rectified the syntax error in the `ServiceWorkerUninitialiser` JavaScript code, which was causing an issue on API level 24. Consequently, the main page failed to load on this API level. We've refactored our code to ensure compatibility across all API levels. * Now that our service is functioning correctly, there's no need to explicitly load the main page. Upon service worker uninitialization, the main page automatically loads.
|
@kelson42 This PR is now ready for review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3809
ServiceWorkerUninitialisercode to appropriately uninitialize the service worker. Previously, when the uninitializing code ran from the JavaScript interface, we directly called the function, which sometimes functioned correctly but sometimes did not. To address this inconsistency, we are now invoking that function to ensure the main page loads after the service worker is uninitialized.ServiceWorkerUninitialiserJavaScript code, which was causing an issue on API level 24. Consequently, the main page failed to load on this API level. We've refactored our code to ensure compatibility across all API levels.