Fixed: Touch target size issue reported by the playstore.
#3818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fixed the touch target issue occurring in the HelpFragment screen. Added the `minWidth` and `minHeight`. For manintaing the current design we have done some modification in this screen like adding the padding and `scaleType` otherwise the design was looking very bigger then previous. * Changed the width of `page_switch` to `wrapContent` instead of fixed width which prevents to expansion of the view if there is more content to display. * Increase the height of SearchView's editText to resolve the `Touch target issue`. * Added the minHeight for `deviceName` to touch target issue. Also, added the contentDescription for this textView. * Moved the "Device Name" string to strings.xml file since it was hardcoded here. * Added `minHeight` for showing link textView in external link popup.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3818 +/- ##
============================================
+ Coverage 53.19% 53.20% +0.01%
- Complexity 1310 1311 +1
============================================
Files 292 292
Lines 11052 11062 +10
Branches 1470 1471 +1
============================================
+ Hits 5879 5886 +7
- Misses 4197 4200 +3
Partials 976 976 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3811
minWidthandminHeight. To manage the current design we made modifications to this screen like adding the padding andscaleTypeotherwise, the design would look much bigger than the previous.page_switchtowrapContentinstead of fixed width which prevents to expansion of the view if there is more content to display.Touch target issue.deviceNameto resolve the touch target issue. Also, added the contentDescription for this textView.minHeightfor showing link textView in external link popup.