Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed: The Delete icon is showing wrong content description on the notes and history screen. #3826

Merged
merged 1 commit into from
May 8, 2024

Conversation

MohitMaliFtechiz
Copy link
Collaborator

Fixes #3825

  • Added correct description to delete button on HistoryFragment, and NotesFragment.
Notes screen History screen
ClearNotesFixed ClearHistoryFix
  • Refactored the test case according to this new change.
  • Sometimes actionOnItemAtPosition method gives an internal error, and does not perform the desired operation and fails the NoteFragmentTest. So we have moved it inside the testFlakyView method so that if there is any internal error occurs it retries this action.
org.kiwix.kiwixmobile.note.NoteFragmentTest > testUserCanSeeNotesForDeletedFiles[Pixel_6a_API_24(AVD) - 7.0] FAILED 
        androidx.test.espresso.PerformException: Error performing 'androidx.test.espresso.contrib.RecyclerViewActions$ActionOnItemAtPositionViewAction@1987abf' on view 'view.getId() is <2131296807/org.kiwix.kiwixmobile:id/recycler_view>'.
        at androidx.test.espresso.PerformException$Builder.build(PerformException.java:1)

…tes and history screen.

* Added correct description to delete button on HistoryFragment, and NotesFragment.
* Refactored the test case according to this new change.
* Sometimes actionOnItemAtPosition method gives an internal error, and does not perform the desired operation and fails the NoteFragmentTest. So we have moved it inside the testFlakyView method so that if there is any internal error occurs it retries this action.
Copy link

codecov bot commented May 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.30%. Comparing base (c663059) to head (4a5033f).

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #3826      +/-   ##
============================================
+ Coverage     53.25%   53.30%   +0.04%     
- Complexity     1315     1319       +4     
============================================
  Files           292      292              
  Lines         11060    11067       +7     
  Branches       1471     1471              
============================================
+ Hits           5890     5899       +9     
- Misses         4194     4195       +1     
+ Partials        976      973       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kelson42 kelson42 merged commit 07956eb into main May 8, 2024
10 checks passed
@kelson42 kelson42 deleted the Fix#3825 branch May 8, 2024 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The Delete icon is showing wrong content description on the notes and history screen.
3 participants