Fixed: Zim files are not opening with kiwix when clicking from the storage. #3834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3834 +/- ##
============================================
+ Coverage 53.28% 53.83% +0.55%
- Complexity 1317 1324 +7
============================================
Files 292 292
Lines 11067 11078 +11
Branches 1471 1471
============================================
+ Hits 5897 5964 +67
+ Misses 4194 4131 -63
- Partials 976 983 +7 ☔ View full report in Codecov by Sentry. |
|
@MohitMaliFtechiz Please add test for the local loading of external ZIM files. |
MohitMaliFtechiz
force-pushed
the
Fix#3832
branch
from
ab43d12
to
b495513
Compare
…orage. * Corrected the deep linking for `content` type scheme. * Improved the handling of zim files if user opens from the storage and our application is not in background. * Improved the opening of Zim files when we open directly from storage. * Also, added necessary comments on the changes to properly understand why we have done these changes.
* Testing for both `file` and `content` scheme type uris.
MohitMaliFtechiz
force-pushed
the
Fix#3832
branch
from
b495513
to
1b596ec
Compare
|
@kelson42 I have added the test cases, and now this PR is ready for review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3832
contenttype scheme.FixedStorageDeepLink.mp4