Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Service workers not enabled/supported in current app #290

Closed
ikreymer opened this issue Jul 14, 2020 · 5 comments
Closed

Service workers not enabled/supported in current app #290

ikreymer opened this issue Jul 14, 2020 · 5 comments
Assignees
Labels

Comments

@ikreymer
Copy link

Similar to kiwix/kiwix-desktop#487, the embedded WKWebView does not appear to support service workers.
They would be needed for the new replay system.

It's not entirely clear if WKWebView supports them fully, see:
https://developer.apple.com/forums/thread/126923 it may require a different approach or using Safari directly,
or maybe this has changed.

(I tried the existing app on MacOS, ran into issues when trying to build locally per instructions. Can open separate issue for that)

@kelson42
Copy link
Contributor

@automactic This is a critical problem as we plan to put in production ZIM files using service workers in Q4 of this year. Would you be able to give us quickly a feedback on this?

@kelson42
Copy link
Contributor

@automactic @ikreymer Should we consider this is the same bug/ticket for iOS and macOS or should we open a separate ticket?

@rgaudin
Copy link
Member

rgaudin commented Jul 20, 2020

@kelson42 we can keep a single ticket until this gets implemented as both iOS and macOS uses WKWebView (although implemented at different locations).

Service workers (whatever the scheme – both app uses kiwix://) won't work on current iOS 13 nor Autumn expected iOS14 as per this SO answer

tldr: the feature has been implemented but it requires a permission (entitlement) which can not be requested on the store backend.

@stale
Copy link

stale bot commented Oct 14, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.

@stale stale bot added the stale label Oct 14, 2020
@kelson42
Copy link
Contributor

Basically a duplicate of #341

@stale stale bot removed the stale label May 28, 2023
@kelson42 kelson42 self-assigned this May 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants