793 supporting entries ending in "/" #797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Jun 8, 2024
kelson42
force-pushed
the
793-supporting-entries-ending-in
branch
from
e24e4ed
to
abf92d3
Compare
|
I guess this PR is blocked / depends on #796 ?! |
rgaudin
previously approved these changes
Jun 9, 2024
kelson42
force-pushed
the
793-bump-up-min-version-to-mac13-ios16
branch
from
f7ae0cc
to
91648c7
Compare
kelson42
force-pushed
the
793-supporting-entries-ending-in
branch
from
abf92d3
to
cc4c2aa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #793
Made sure that we suport urls to contentPath ending with "/",
we drop if there's any "#" symbol with additional arguments there (which was also failing).
Fixed the issue with the error pop-up, now only a failing "main" document should trigger the pop-up.
Tested with "Mes quartiers chinois":