Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix share/export content depending on it's type #820

Merged
merged 5 commits into from
Jun 19, 2024

Conversation

BPerlakiH
Copy link
Collaborator

Fixes: #814

@BPerlakiH BPerlakiH linked an issue Jun 19, 2024 that may be closed by this pull request
rgaudin
rgaudin previously approved these changes Jun 19, 2024
Copy link
Member

@rgaudin rgaudin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ; with a comment :)

ViewModel/BrowserViewModel.swift Show resolved Hide resolved
@kelson42
Copy link
Contributor

@BPerlakiH LGTM, but please fix CodeFactor error

Copy link
Contributor

@kelson42 kelson42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kelson42 kelson42 merged commit 1e3f9ce into main Jun 19, 2024
4 checks passed
@kelson42 kelson42 deleted the 814-export-of-a-pdf-fails branch June 19, 2024 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Export of a PDF fails
3 participants