Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new target "platform" for WebAssembly (compile libzim to Wasm) #503

Closed
mossroy opened this issue Oct 27, 2021 · 9 comments · Fixed by #548
Closed

Add a new target "platform" for WebAssembly (compile libzim to Wasm) #503

mossroy opened this issue Oct 27, 2021 · 9 comments · Fixed by #548
Assignees

Comments

@mossroy
Copy link

mossroy commented Oct 27, 2021

Compiled with emscripten, to produce libzim.a and other libraries.
libkiwix is probably not necessary : libzim should be enough for now.

It should :

@mossroy
Copy link
Author

mossroy commented Oct 27, 2021

Maybe there is a better way to avoid compiling useless components (examples etc) of icu and libzim than modifying Makefile.in and meson.build

@mossroy
Copy link
Author

mossroy commented Oct 29, 2021

When it's ready, it should also compile the bindings, see kiwix/kiwix-js#768

@stale
Copy link

stale bot commented Apr 16, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.

@stale stale bot added the stale label Apr 16, 2022
@mossroy
Copy link
Author

mossroy commented Jun 3, 2022

Now that kiwix/kiwix-js#513 is solved, it's a major blocker that goes out of the way for libzim wasm.
This ticket would allow to integrate the libzim wasm compilation in the CI, like for other platforms

@kelson42
Copy link
Contributor

kelson42 commented Jun 4, 2022

@mossroy @mgautierfr OK, we shoukd move forward on this ASAP

@kelson42
Copy link
Contributor

kelson42 commented Jun 6, 2022

I'm not in favour of expecting developers to compile the libzim themself; for any binding, Javascript included.

IMO, the goal should be to provide a directly usable libzim in Javascript.

From a technical POV, this implies to create & publish the WASM file and a/the corresponding Javascript file allowing to exploit the .wasm file in Javascript. With both files, any browser supporting WebAssembly should be able to exploit the libzim.

@mossroy Do I understand properly? Would that satisfy your request?

@kelson42 kelson42 changed the title Add a new target "platform" for WebAssembly Add a new target "platform" for WebAssembly (compile libzim to Wasm) Jun 6, 2022
@mossroy
Copy link
Author

mossroy commented Jun 6, 2022

Yes, you understood properly, and that would be perfect.

As I told you, we are not currently blocked, as we can compile by ourself.
But what you propose is the clean way to do it in the mid-term.

It means that the CI would provide all the necessary bindings, like you do for python.
Feel free to move kiwix/kiwix-js#768 to the corresponding github project

@kelson42
Copy link
Contributor

kelson42 commented Jun 6, 2022

@mossroy Thank you for the confirmation.
@mgautierfr We have to decide if:

  • Either this is an output of the Libzim CD
  • Or we created a dedicated repository libzim-javascript.

Which one do you want to follow?

@stale
Copy link

stale bot commented Sep 21, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants