Zimwriterfs #21
Merged
Zimwriterfs #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mgautierfr I do no really understand why kiwix has a build dependency to zimwriterfs? |
|
This PR mainly add the possibility to build the zimwritterfs with kiwix-build.py. BTW, Why have you merged the |
The OpenZim source contains the zimlib source but also the zimwriterfs source. There is no zimwriterfs dependency for now but it is better to separate source from the dependency for latter commit.
This is different from declaring a dependency as dependency may be build by kiwix-build.py.
Now kiwix-build.py can compile zimwriterfs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for zimwriterfs in kiwix-build.py