Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add version and help commandline options #631

Merged
merged 1 commit into from May 19, 2021

Conversation

HanYoung-uwu
Copy link
Contributor

As requested by #602

@kelson42 kelson42 requested a review from mgautierfr May 2, 2021 16:35
@kelson42
Copy link
Collaborator

kelson42 commented May 2, 2021

@HanYoung-uwu Thank you very much

Copy link
Member

@mgautierfr mgautierfr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small change. Everything else is good.

src/main.cpp Outdated
Comment on lines 10 to 11
#define _STR(...) # __VA_ARGS__
#define STR(X) _STR(X)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need this, it is already in src/kiwixapp.h

@HanYoung-uwu
Copy link
Contributor Author

force pushed

@kelson42
Copy link
Collaborator

@legoktm Hope this looks good to you?

@kelson42 kelson42 merged commit 20a66f9 into kiwix:master May 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants