FileDialog style and other efficiency fixes #634
Conversation
|
I see no visible change on Ubuntu, I guess this impacts only Windows users. |
Well, this does impact me who is on Arch/KDE. |
Is your filedialog like the second picture above? |
|
@HanYoung-uwu This is how it looks like for me |
So in your case, QFileDialog opens native filedialog using XDG, your native filedialog is gnome so Qt style doesn't affect you. But for system which native filedialog is written in Qt, ugly windows theme is used. |
There was a problem hiding this comment.
Two small changes on the git commits.
Noting to say on the code itself.
Remove close() on QFile because it close file in destructor, call it here you pay one more check on destructing (and extra line of code)
This comment could be put in the commit message itself
("Don't close the QFile explicitly as it will be close anyway in the destructor.")
src/kiwixapp.cpp
Outdated
| getMainWindow(), | ||
| gt("open-zim"), | ||
| QString(), | ||
| "ZimFile (*.zim*)"); | ||
|
|
||
| if (_zimfile.isEmpty()) { | ||
| return; | ||
| } | ||
| _zimfile = QDir::toNativeSeparators(_zimfile); |
There was a problem hiding this comment.
This change should be made in previous commit.
HanYoung-uwu
force-pushed
the
work/filedialog
branch
from
7fbfb9c
to
250bf5e
Compare
|
force pushed. Please re-review |
|
We are good. Thanks ! |
Setting windows style on non-windows platform makes FileDialog looks hideous.
Note that "Windows" style is not what you usually want even if you like windows style. "QWindowsVistaStyle" is what people usually choose.
Other changes include:
KiwixApp::openZimFileclose()on QFile because it close file in destructor, call it here you pay one more check on destructing (and extra line of code)