Improvements to Settings Panel #719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kelson42
approved these changes
Nov 12, 2021
mgautierfr
requested changes
Nov 15, 2021
There was a problem hiding this comment.
We are good on the code.
I would prefer a better commit message however.
The current one is a bit to general and do not say what is done.
You can think of the commit title (the first line) as a description of what is done and what will be put in the Changelog.
It would be better to have something like "Change existing tab's zoom when setting's zoom is changed"
The same way (but it is to be pedantic, and I will not block the PR for this), as you are doing two different, unrelated things (change the labeling and change the behavior), it would have been nice to have two commits.
|
Thank you for the suggestions! I have followed them (and also learned how to split a commit into 2 xD) |
mgautierfr
approved these changes
Nov 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #718