Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix compilation after removing of wrapping in libkiwix #858

Merged
merged 3 commits into from Jul 8, 2022
Merged

Fix compilation after removing of wrapping in libkiwix #858

merged 3 commits into from Jul 8, 2022

Conversation

mgautierfr
Copy link
Member

Following the merge of kiwix/libkiwix#789 we have to adapt a bit the code here.

@mgautierfr mgautierfr requested a review from juuz0 July 8, 2022 14:37
juuz0
juuz0 approved these changes Jul 8, 2022
View reviewed changes
Copy link
Collaborator

@juuz0 juuz0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and everything works fine 👍

@kelson42 kelson42 merged commit f1aafc1 into master Jul 8, 2022
@kelson42 kelson42 deleted the fix_compilation branch July 8, 2022 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juuz0 juuz0 juuz0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mgautierfr @juuz0 @kelson42