Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a small hack to fix QWebEngine using appimage. #905

Merged
merged 1 commit into from Nov 23, 2022
Merged

Add a small hack to fix QWebEngine using appimage. #905

merged 1 commit into from Nov 23, 2022

Conversation

mgautierfr
Copy link
Member

Fix #810

@mgautierfr
Copy link
Member Author

Generated appimage with this workaround can be found here : http://tmp.kiwix.org/ci/appimage-hack/kiwix-desktop_x86_64_2022-11-22.appimage

veloman-yunkan
veloman-yunkan reviewed Nov 23, 2022
View reviewed changes
src/main.cpp Outdated Show resolved Hide resolved
veloman-yunkan
veloman-yunkan reviewed Nov 23, 2022
View reviewed changes
Copy link
Collaborator

@veloman-yunkan veloman-yunkan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMBNRF

@kelson42 kelson42 merged commit 0d0aa05 into master Nov 23, 2022
@kelson42 kelson42 deleted the appimage-hack branch November 23, 2022 16:04
mgautierfr added a commit that referenced this pull request Nov 30, 2022
@mgautierfr
New version 2.3.1
7cd4a02 
 * Fix the AppImage packaging. Now published AppImages work correctly on recent
   distrubution (@mgautierfr #905)
 * Improve zim file picker (@kelson42 #886)
 * Do not show ServiceWorker zim file from the remote catalog (@kelson42 #887)
@mgautierfr mgautierfr mentioned this pull request Nov 30, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veloman-yunkan veloman-yunkan veloman-yunkan left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

kiwix-desktop appimage webengine is broken on Fedora (and ubuntu 22.04)
3 participants
@mgautierfr @veloman-yunkan @kelson42