Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some recent ZIMs appear not to load even though they have loaded #74

Closed
Jaifroid opened this issue Apr 28, 2019 · 2 comments
Closed

Some recent ZIMs appear not to load even though they have loaded #74

Jaifroid opened this issue Apr 28, 2019 · 2 comments
Assignees
Labels
Milestone

Comments

@Jaifroid
Copy link
Member

A user has reported that with the latest update, they can't get Kiwix JS Windows to remember the loaded ZIM file, and have to pick it again each time they open the app. While I can't reproduce the issue in quite that way, I have uncovered a similar issue which I believe is in fact this problem. The issue is that with the latest ZIM format (e.g. wikipedia_en_100_2019-01.zim) the app opens the Ray Charles home page even after selecting the new ZIM. However, if the user then searches for an article, they will find that the new ZIM is in fact loaded and is searchable. After going to an article in the new ZIM, the user can press the Home button and will be taken to the new ZIM's home page instead of Ray Charles. From then on, the new ZIM shows as properly loaded, even after a restart.

This behaviour only occurs with the new ZIMs that have indices (possibly also with images) for home pages. I suspect that the app doesn't find some referenced home page and then launches the previously saved page (most likely Ray Charles) instead. This shouldn't be too hard to fix.

@Jaifroid Jaifroid added the bug label Apr 28, 2019
@Jaifroid Jaifroid added this to the High priority milestone Apr 28, 2019
@Jaifroid Jaifroid self-assigned this Apr 28, 2019
Jaifroid added a commit that referenced this issue Apr 28, 2019
Addresses #74 and also a bug that caused the page to display before the CSS files had all been loaded (also caused double loading of some pages)
@Jaifroid
Copy link
Member Author

This should now be fixed in the dev branch. I'm going to push it to a new release after testing on mobile, because this could cause serious confusion to users.

@Jaifroid
Copy link
Member Author

Tested and working on mobile.

Jaifroid added a commit that referenced this issue Apr 29, 2019
Addresses #74 and also a bug that caused the page to display before the CSS files had all been loaded (also caused double loading of some pages)
Jaifroid added a commit that referenced this issue Jul 1, 2019
Addresses #74 and also a bug that caused the page to display before the CSS files had all been loaded (also caused double loading of some pages)
@Jaifroid Jaifroid closed this as completed Jan 5, 2020
@Jaifroid Jaifroid modified the milestones: High priority, Release 1.5.0 Aug 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant