Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ZIM info to the security dialogue box when opening a ZIM for the first time #1247

Closed
Jaifroid opened this issue May 3, 2024 · 6 comments · Fixed by #1250
Closed

Add ZIM info to the security dialogue box when opening a ZIM for the first time #1247

Jaifroid opened this issue May 3, 2024 · 6 comments · Fixed by #1250
Assignees
Milestone

Comments

@Jaifroid
Copy link
Member

Jaifroid commented May 3, 2024

See Kiwix PWA for existing implementation. I propose simply providing the same info as in screenshot:

image

@Jaifroid Jaifroid added this to the v4.1 milestone May 3, 2024
@Jaifroid Jaifroid self-assigned this May 3, 2024
@D3V-D
Copy link
Contributor

D3V-D commented May 4, 2024

I'd also be interested in helping in this issue if help is needed. @Jaifroid

@Jaifroid
Copy link
Member Author

Jaifroid commented May 5, 2024

I'd also be interested in helping in this issue if help is needed. @Jaifroid

Happy for you to do it -- it should be pretty easy to use the PWA template/code for this. The only complication is adding the translation strings. Also, instead of "can easily be spoofed" I think it would be more accurate to say "can be spoofed" (and I'll probably change that in the PWA when I've finished another PR I'm working on).

@Jaifroid Jaifroid assigned D3V-D and unassigned Jaifroid May 5, 2024
@Jaifroid
Copy link
Member Author

Jaifroid commented May 5, 2024

Oh, and you'll need to make sure all the required metadata are available when the ZIM first opens, which may require a small change to zimArchive.js.

@D3V-D
Copy link
Contributor

D3V-D commented May 5, 2024

Yeah, once I take a look at it ill let you know what I think. I have yet to work with "translation strings" - is that the alternate language versions of the text i assume?

@Jaifroid
Copy link
Member Author

Jaifroid commented May 5, 2024

@D3V-D Yes, I've implemented French and Spanish (as well as English) in Kiwix JS (but not in the PWA). It's sort of obvious how it's done when you look at it -- there are lots of examples of invoking a dialogue box like that with the language string keys, and then the translation backend takes care of displaying the appropriate language. You can use https://www.deepl.com/translator to get the French and Spanish versions (but that comes at the end, after code is working). I can check French and Spanish, as I know these languages.

@D3V-D
Copy link
Contributor

D3V-D commented May 9, 2024

Sorry I haven't had time to take a good look at the issue. I have exams for the next week or two, but after that I'll be able to do some work on this issue.

Just a heads-up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants