Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add QUnit test for conversion of WebP images #674

Closed
Jaifroid opened this issue Nov 22, 2020 · 2 comments
Closed

Add QUnit test for conversion of WebP images #674

Jaifroid opened this issue Nov 22, 2020 · 2 comments
Assignees
Milestone

Comments

@Jaifroid
Copy link
Member

Following on from #670 (comment), once #672 is complete, we should add a QUnit test for WebP image reading:

It would be good to add a QUnit test on feedNodeWithBlob function : it could create a DOM image element, call this function with a webp content (like the sample image with 2 pixels height), and the check its height afterwards.
This might probably need to refactor this function a bit : add a callback parameter or make it return a Promise, so that the unit test can know when the image has been decoded.

@Jaifroid Jaifroid added this to the v3.1 milestone Nov 22, 2020
@Jaifroid Jaifroid self-assigned this Nov 22, 2020
@Jaifroid Jaifroid modified the milestones: v3.1, v3.2 Dec 6, 2020
@kelson42
Copy link
Collaborator

kelson42 commented Aug 22, 2021

The value of such a unit test decreases rapidly over time because less and less people use a Browser without native webp support.

@mossroy mossroy modified the milestones: v3.2, v3.3 Aug 22, 2021
@mossroy
Copy link
Contributor

mossroy commented Aug 22, 2021

This should be superseded by #748 that should have a UI test that checks that an image is displayed (and check its dimensions).
If we keep running this scenario on browsers that do not support webp (IE11, Firefox 45), it will check that conversion of webp images work.
I agree with you that it would be enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants