Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

On the Peak device, the text and buttons are too small, on Firefox OS <1.1 #8

Closed
mossroy opened this issue Jun 10, 2013 · 6 comments
Closed

On the Peak device, the text and buttons are too small, on Firefox OS <1.1 #8

mossroy opened this issue Jun 10, 2013 · 6 comments
Labels
enhancement
Milestone
v1.0.3

Comments

@mossroy
Copy link
Contributor

mossroy commented Jun 10, 2013

It might be related to the experimental hidpi on this device
@mossroy
Copy link
Contributor Author

mossroy commented Jul 12, 2013

I reopen this issue.
It works great on Peak, but does not work so great on smaller screens :
Some parts of the article are off-screen.
For example, on the small dump, if you display "Abraham Lincoln" article, the first table (with CSS style vbox" is truncated on the left.

So I have to revert the rem sizes for now

@mossroy mossroy reopened this Jul 12, 2013
@mossroy
Copy link
Contributor Author

mossroy commented Jul 15, 2013

Maybe this is a Peak-specific issue. I heard that the 1.1 branch of Firefox OS (with patches from Geeksphone) might solve this issue

@mossroy mossroy mentioned this issue Jul 28, 2013
Closed
@mossroy
Copy link
Contributor Author

mossroy commented Aug 10, 2013

I don't feel to have this issue on the Keon device

@mossroy
Copy link
Contributor Author

mossroy commented Aug 23, 2013

The 1.1 version of Firefox OS should be soon considered as stable (~1 month ?).
Based on http://forum.geeksphone.com/index.php?topic=5592.0 , geeksphone will deploy 1.1 OTA at this moment.

For now, I added a warning message in the application if the screen resolution is the one of the Peak device (which is a very unreliable test, but it appears to be the only Firefox OS device with this resolution for now). This warning will have to be removed as soon as 1.1 is deployed OTA

mossroy added a commit that referenced this issue Aug 23, 2013
@mossroy
Display a warning message if the device is probably a Peak (based on …
181fcbb 
…the screen resolution), so that the user knows that the text is very small in Firefox OS 1.0.1. This should be fixed in Firefox OS 1.1

This improves a bit #8
@mossroy
Copy link
Contributor Author

mossroy commented Oct 14, 2013

After testing a bit Firefox OS v1.1, I confirm it solves this issue

@mossroy
Copy link
Contributor Author

mossroy commented Nov 21, 2013

Firefox OS 1.1 has been released as stable and deployed to Peak devices, so I close this issue

@mossroy mossroy closed this as completed Nov 21, 2013
mossroy added a commit that referenced this issue Nov 22, 2013
@mossroy
Remove the code that warns the user if he has a Peak device (because …
4625781 
…of small font in FxOS 1.0.1. See #8).

Now that FxOS 1.1 has been deployed, it is not necessary any more
mossroy added a commit that referenced this issue Dec 31, 2013
@mossroy
Remove the code that warns the user if he has a Peak device (because …
3b833db 
…of small font in FxOS 1.0.1. See #8).

Now that FxOS 1.1 has been deployed, it is not necessary any more
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
v1.0.3
Development

No branches or pull requests
1 participant
@mossroy