-
-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Folder structure redone for tests
#1064
Conversation
I have left out |
Happy for you to propose something, or just structure the e2e tests, as you wish! |
@Jaifroid I think its good enough to merge now then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good, and much more organized, thank you! There's one small change (see comment).
Many thanks for this PR. Squashing/merging now. |
@RG7279805 Unfortunately, it looks like this PR broke the BrowserStack implementation, and of course that didn't get tested in your testing of it, because BrowserStack tests can't run with PRs from forked repositories. I'm re-running the tests, but we might have to revert. I'm also getting failures on my internationalization branch that appear to be caused by the PR. |
Hmm, definitely failing, check out: https://github.com/kiwix/kiwix-js/actions/runs/5951851073/job/16149678973 and https://github.com/kiwix/kiwix-js/actions/runs/5953037189/job/16146376792?pr=1061. I tried to fix the paths for the legacy edge runner on my branch, but it still fails. |
So, I've reverted for now, but your PR is saved at this commit: It probably needs some adjustment, but I can't seem to work out what at the moment, and you will have a clearer idea of what changed. |
That would be great. Please don't worry about this small setback -- you couldn't have known because the tests weren't run and you don't have access to the BrowserStack setup yet. As soon as I've merged the internationalization branch, I'll turn to working out best way to give you access. Perhaps you could send me a slack message with the best email address for me to invite you to be a member of the team able to view test videos etc. on BrowserStack. |
I have sent you a message on Slack until then I will wait |
closes #1062